Memory and Secret Handling Fixes by stenslae · Pull Request #589 · wolfSSL/wolfssl-examples

stenslae · 2026-07-06T18:39:32Z

27 Fenrir fixes across wolfSSL example code in three commits:

Buffer/malloc safety (crypto file-encryption examples): fix buffer overflows, missing malloc/realloc NULL checks, and padding validation in AES/3DES/Camellia file-encrypt tools.
Memory/lifecycle bugs: fix NULL-deref, fd leaks, unaligned access, and buffer overflows across CAN bus, PKCS7, embedded, and PEM-printing examples.
Key/secret handling: replace hardcoded or UAF-prone secrets/keys with RNG-generated values, zeroize key material before free, and flag non-constant-time secret comparisons.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #589

Scan targets checked: wolfssl-examples-bugs, wolfssl-examples-src

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #589

Scan targets checked: wolfssl-examples-bugs, wolfssl-examples-src

No new issues found in the changed files. ✅

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #589

Scan targets checked: wolfssl-examples-bugs, wolfssl-examples-src

No new issues found in the changed files. ✅

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #589

Scan targets checked: wolfssl-examples-bugs, wolfssl-examples-src

Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #589

Scan targets checked: wolfssl-examples-bugs, wolfssl-examples-src

Findings: 3
3 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #589

Scan targets checked: wolfssl-examples-bugs, wolfssl-examples-src

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

padelsbach · 2026-07-14T15:51:48Z

@stenslae this one now has conflicts

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #589

Scan targets checked: wolfssl-examples-bugs, wolfssl-examples-src

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #589

Scan targets checked: wolfssl-examples-bugs, wolfssl-examples-src

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

…s, malloc/realloc NULL checks, and padding validation in crypto file-encryption examples

… F-6288: fix NULL-deref, fd-leak, unaligned-access, and buffer-overflow bugs across CAN, PKCS7, embedded, and PEM-printing examples

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #589

Scan targets checked: wolfssl-examples-bugs, wolfssl-examples-src

Findings: 3
3 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #589

Scan targets checked: wolfssl-examples-bugs, wolfssl-examples-src

Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

…ce hardcoded/UAF-prone secrets and keys with RNG-generated values, zeroize key material before free, and flag non-constant-time secret comparisons

stenslae requested a review from wolfSSL-Fenrir-bot July 6, 2026 18:39

stenslae self-assigned this Jul 6, 2026

wolfSSL-Fenrir-bot reviewed Jul 6, 2026

View reviewed changes

Comment thread ccb_vaultic/ccb_vaultic.c

stenslae force-pushed the pr-memory-crypto branch from 9e04469 to d324400 Compare July 6, 2026 19:59

stenslae commented Jul 6, 2026

View reviewed changes

Comment thread ccb_vaultic/ccb_vaultic.c

stenslae requested a review from wolfSSL-Fenrir-bot July 6, 2026 19:59

wolfSSL-Fenrir-bot reviewed Jul 6, 2026

View reviewed changes

stenslae assigned wolfSSL-Bot Jul 6, 2026

stenslae force-pushed the pr-memory-crypto branch from d324400 to 34ccbb9 Compare July 7, 2026 15:40

stenslae requested a review from wolfSSL-Fenrir-bot July 7, 2026 15:41

wolfSSL-Fenrir-bot reviewed Jul 7, 2026

View reviewed changes

stenslae removed their assignment Jul 7, 2026

stenslae force-pushed the pr-memory-crypto branch 3 times, most recently from c4beee5 to 76b1000 Compare July 9, 2026 21:56

stenslae requested a review from wolfSSL-Fenrir-bot July 9, 2026 21:56

wolfSSL-Fenrir-bot reviewed Jul 9, 2026

View reviewed changes

Comment thread crypto/aes/aes-file-encrypt.c

Comment thread dtls/dtls-export-common.h Outdated

stenslae force-pushed the pr-memory-crypto branch 2 times, most recently from d490b56 to e399570 Compare July 9, 2026 22:46

stenslae requested a review from wolfSSL-Fenrir-bot July 9, 2026 22:47

stenslae commented Jul 9, 2026

View reviewed changes

Comment thread dtls/dtls-export-common.h Outdated

stenslae commented Jul 9, 2026

View reviewed changes

Comment thread crypto/aes/aes-file-encrypt.c

wolfSSL-Fenrir-bot reviewed Jul 9, 2026

View reviewed changes

Comment thread crypto/aes/aes-file-encrypt.c

Comment thread dtls/dtls-export-common.h Outdated

Comment thread crypto/aes/aesgcm-file-encrypt.c

stenslae marked this pull request as draft July 10, 2026 15:59

stenslae assigned stenslae and unassigned wolfSSL-Bot Jul 10, 2026

stenslae commented Jul 10, 2026

View reviewed changes

Comment thread dtls/dtls-export-common.h Outdated

stenslae commented Jul 10, 2026

View reviewed changes

Comment thread crypto/aes/aesgcm-file-encrypt.c

stenslae force-pushed the pr-memory-crypto branch from e399570 to 3912200 Compare July 10, 2026 19:13

stenslae requested a review from wolfSSL-Fenrir-bot July 10, 2026 19:14

stenslae removed the request for review from wolfSSL-Fenrir-bot July 13, 2026 22:32

stenslae force-pushed the pr-memory-crypto branch from 0616752 to 2e36f5b Compare July 13, 2026 22:51

stenslae requested a review from wolfSSL-Fenrir-bot July 13, 2026 22:52

wolfSSL-Fenrir-bot reviewed Jul 13, 2026

View reviewed changes

Comment thread crypto/aes/aes-file-encrypt.c Outdated

stenslae commented Jul 14, 2026

View reviewed changes

Comment thread crypto/aes/aes-file-encrypt.c Outdated

stenslae force-pushed the pr-memory-crypto branch from 2e36f5b to 0f12168 Compare July 14, 2026 15:45

stenslae requested a review from wolfSSL-Fenrir-bot July 14, 2026 15:47

wolfSSL-Fenrir-bot reviewed Jul 14, 2026

View reviewed changes

Comment thread dtls/dtls-export-common.h Outdated

stenslae force-pushed the pr-memory-crypto branch from 0f12168 to e8978aa Compare July 14, 2026 16:10

stenslae commented Jul 14, 2026

View reviewed changes

Comment thread dtls/dtls-export-common.h Outdated

stenslae requested a review from wolfSSL-Fenrir-bot July 14, 2026 16:13

wolfSSL-Fenrir-bot reviewed Jul 14, 2026

View reviewed changes

Comment thread crypto/3des/3des-file-encrypt.c

stenslae commented Jul 14, 2026

View reviewed changes

Comment thread crypto/3des/3des-file-encrypt.c

Emma Stensland added 2 commits July 14, 2026 10:45

F-1302 F-1303 F-1304 F-1308 F-3471 F-3691 F-4601: fix buffer overflow…

8affb93

…s, malloc/realloc NULL checks, and padding validation in crypto file-encryption examples

F-1305 F-1306 F-1714 F-2111 F-2905 F-2906 F-2909 F-3897 F-4125 F-4608…

7387eb1

… F-6288: fix NULL-deref, fd-leak, unaligned-access, and buffer-overflow bugs across CAN, PKCS7, embedded, and PEM-printing examples

stenslae force-pushed the pr-memory-crypto branch from e8978aa to 726744a Compare July 14, 2026 16:46

stenslae requested a review from wolfSSL-Fenrir-bot July 14, 2026 16:46

wolfSSL-Fenrir-bot reviewed Jul 14, 2026

View reviewed changes

Comment thread crypto/3des/3des-file-encrypt.c Outdated

Comment thread crypto/camellia/camellia-encrypt.c Outdated

Comment thread dtls/dtls-export-common.h

stenslae commented Jul 14, 2026

View reviewed changes

Comment thread dtls/dtls-export-common.h

stenslae commented Jul 14, 2026

View reviewed changes

Comment thread crypto/camellia/camellia-encrypt.c Outdated

stenslae commented Jul 14, 2026

View reviewed changes

Comment thread crypto/3des/3des-file-encrypt.c Outdated

stenslae force-pushed the pr-memory-crypto branch from 726744a to caea419 Compare July 14, 2026 17:39

stenslae requested a review from wolfSSL-Fenrir-bot July 14, 2026 17:40

wolfSSL-Fenrir-bot reviewed Jul 14, 2026

View reviewed changes

Comment thread crypto/aes/aes-file-encrypt.c

Comment thread dtls/dtls-export-common.h

F-1715 F-2114 F-3224 F-3690 F-4120 F-4123 F-4124 F-5614 F-5615: repla…

7b56dd5

…ce hardcoded/UAF-prone secrets and keys with RNG-generated values, zeroize key material before free, and flag non-constant-time secret comparisons

stenslae force-pushed the pr-memory-crypto branch from caea419 to 7b56dd5 Compare July 14, 2026 19:22

stenslae requested a review from wolfSSL-Fenrir-bot July 14, 2026 19:23

padelsbach approved these changes Jul 14, 2026

View reviewed changes

padelsbach merged commit 210e9ca into wolfSSL:master Jul 14, 2026

Uh oh!

Conversation

stenslae commented Jul 6, 2026

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #589

Uh oh!

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #589

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #589

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #589

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #589

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #589

Uh oh!

Uh oh!

Uh oh!

padelsbach commented Jul 14, 2026

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #589

Uh oh!

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #589

Uh oh!

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #589

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #589

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants